Looks like this should be initialized to 1. As the first if statement

that changes the item sets it to 0 if no arg2 exists(which makes sense).
Normal command operation is @atrlock obj=lock, or @atrlock obj.
Thus no arg2 would be unlocking, and with arg2 would be a lock
operation.

IssueID #246

diff --git a/src/attrib.c b/src/attrib.c
index 9765d62798a406eabfcec843a1cf9988f21cffcc..9123efee67737ed75063029b03f7e01c7bf0dcb4 100644 (file)
--- a/src/attrib.c
+++ b/src/attrib.c
@@ -2085,7 +2085,7 @@ do_atrlock(dbref player, const char *xarg1, const char *arg2,
   dbref thing, creator;
   char *p, *arg1;
   ATTR *ptr;
-  int status = 0; /* FIXME: temporary workaround, see #246 */
+  int status = 1; /* FIXME: Issue should be in testing, see #246 */
   boolexp key;
 
   if (!arg2 || !*arg2)