Fixed possible crash in process_commands()

(cherry picked from commit f467ff30ec3f58b40f5a38a234f9ccd2d2f30276)

diff --git a/game/txt/changes/0.72p4 b/game/txt/changes/0.72p4
index c5cd3ca1783bfee4df946c2f1225f538e0e8231f..8f14d6f09398a51474a9fb6b0c5224ce4cb0052a 100644 (file)
--- a/game/txt/changes/0.72p4
+++ b/game/txt/changes/0.72p4
@@ -25,3 +25,4 @@ CobraMUSH Version 0.72p4
     * Typo in Wizard's max and auto power lists on default for the Nuke power. [RLB]
     * Anyone can now set INHERITABLE on himself regardless of having the
       Privilege power [AEJ]
+    * Fixed possible crash in process_commands() [AEJ]

diff --git a/src/bsd.c b/src/bsd.c
index a1e15f85f29571a61688f8c6c11dcbe40b566c57..54cdf58726f0ab06940bc381cb49ccf75a85079e 100644 (file)
--- a/src/bsd.c
+++ b/src/bsd.c
@@ -5514,25 +5514,24 @@ void feed_snoop(DESC *d, const char *s, char dir) {
   int n;
   char snstr[BUFFER_LEN];
 
-
-  if(!d ||!d->connected)
+  if(!d || !d->connected)
     return;
   memset(snstr, '\0', BUFFER_LEN);
   strncpy(snstr, remove_markup(s, NULL), BUFFER_LEN-1);
   if(*s && !*snstr)
-         return;
-  for(n = 0; n < MAX_SNOOPS ; n++)
-    if(!IsPlayer(d->snooper[n]))
+    return;
+  for(n = 0; n < MAX_SNOOPS ; n++) {
+    if(!GoodObject(d->snooper[n]) || !IsPlayer(d->snooper[n]))
       continue;
-    else if(GoodObject(d->snooper[n]) && IsPlayer(d->snooper[n])) {
-      if(dir == 1) /* player see's */
-        notify_format((dbref) d->snooper[n], T("%s%s<-%s %s"), object_header(d->snooper[n],d->player), ANSI_BLUE,
-           ANSI_NORMAL, snstr);
-      else /* player types */
-       notify_format((dbref) d->snooper[n], T("%s%s->%s %s%s"), object_header(d->snooper[n],d->player), 
-           ANSI_BLUE, ANSI_RED, snstr, ANSI_NORMAL);
-    }
-
+    if(dir == 1) /* player sees */
+      notify_format((dbref) d->snooper[n], T("%s%s<-%s %s"),
+                       object_header(d->snooper[n],d->player),
+                       ANSI_BLUE, ANSI_NORMAL, snstr);
+    else /* player types */
+      notify_format((dbref) d->snooper[n], T("%s%s->%s %s%s"),
+                       object_header(d->snooper[n],d->player),
+                       ANSI_BLUE, ANSI_RED, snstr, ANSI_NORMAL);
+  }
 }
 
 char is_snooped(DESC *d) {